Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudformation: Fix bug when updating stack's termination_protection with create_changeset set #2391

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

cloudformation: Fix bug when updating stack's termination_protection with create_changeset set #2391

wants to merge 2 commits into from

Conversation

mandar242
Copy link
Contributor

@mandar242 mandar242 commented Nov 15, 2024 •
edited
Loading

SUMMARY

Fixes #2149
Fix bug where termination protection is not updated when create_changeset=true is used for stack updates

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloudformation

ADDITIONAL INFORMATION

@mandar242 mandar242 mentioned this pull request Nov 15, 2024
Open
1 task
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2e5df5c2dddd43669e7bddc7aff0dae1

✔️ ansible-galaxy-importer SUCCESS in 5m 34s
✔️ build-ansible-collection SUCCESS in 10m 11s
✔️ ansible-test-splitter SUCCESS in 3m 53s
✔️ integration-amazon.aws-1 SUCCESS in 15m 26s
Skipped 43 jobs

hakbailey
hakbailey reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@hakbailey hakbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add an integration test for this case?

abikouo
abikouo approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
Just missing integration tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakbailey hakbailey hakbailey left review comments

@abikouo abikouo abikouo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Termination Protection is not Enabled for Existing Stacks when Create Change Set is Enabled
3 participants
@mandar242 @hakbailey @abikouo