Merge pull request #147 from Gman98ish/fix-url-encoding

No longer urlencodes twice when downloading/uploading attachments
ans-group · Nov 14, 2019 · 7f2c8e3 · 7f2c8e3
2 parents ead0074 + 9921db0
commit 7f2c8e3
Showing 1 changed file with 0 additions and 3 deletions.
diff --git a/src/PSS/ReplyClient.php b/src/PSS/ReplyClient.php
@@ -75,7 +75,6 @@ public function create($requestId, $reply)
      */
     public function upload($replyId, $name, $content)
     {
-        $name = urlencode($name);
         $uri = "v1/replies/$replyId/attachments/$name";
         $response = $this->request('POST', $uri, $content);
 
@@ -92,7 +91,6 @@ public function upload($replyId, $name, $content)
      */
     public function download($replyId, $name)
     {
-        $name = urlencode($name);
         return new Download(
             $this->request('GET', "v1/replies/$replyId/attachments/$name")
         );
@@ -106,7 +104,6 @@ public function download($replyId, $name)
      */
     public function deleteAttachment($replyId, $name)
     {
-        $name = urlencode($name);
         $this->delete("v1/replies/$replyId/attachments/$name");
     }