Python build adjustment #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the binding, link the dynamic C library as built by `make` instead of linking the system-installed C library. This simplifies packaging in Linux distributions and also the build of the live docs.
|
LGTM, thanks. |
TheTumultuousUnicornOfDarkness
merged commit bcd2dea
into
anrieff:master
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of packaging the new bindings for Fedora, I encountered two issues that are resolved in this PR.
The PR changes the way the bindings are built. During the build, the libcpuid dynamic library needs to be linked. Previously, the bindings linked the system-installed library. Now, the shared library is linked from
{repo_directory}/libcpuid/.libs(as built bymake). This should simplify the builds in Linux distributions and the build for the live docs.The sanity tests have been adjusted to pass when the current CPU is not recognized.