Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple errors in the error pop-ups #82

Closed
wants to merge 2 commits into from

Conversation

vrom911
Copy link
Contributor

@vrom911 vrom911 commented May 24, 2023

I am not sure what was the intention of having multiple similar patterns, perhabs that is important. However, after changing that, now I only see 1 error in the pop-up window:

Screenshot 2023-05-24 at 18 43 54

@jonaprieto Let me know if you know the cases, in which these rules were important, so I can test with that too!

@vrom911 vrom911 added the bug Something isn't working label May 24, 2023
@vrom911 vrom911 added this to the 0.2 milestone May 24, 2023
@vrom911 vrom911 requested a review from jonaprieto May 24, 2023 17:54
@vrom911 vrom911 self-assigned this May 24, 2023
@jonaprieto
Copy link
Collaborator

Let me know if you know the cases, in which these rules were important, so I can test with that too!

As far as I remember those patterns were necessary to show the complete error message.
Perhaps, try with a bigger error message like the one given for cycle dependency in module imports.

@jonaprieto
Copy link
Collaborator

jonaprieto commented May 24, 2023

Yes, just try adding a cycle dependency and you'll see that the error popup is not right.

image

@jonaprieto jonaprieto marked this pull request as draft May 30, 2023 17:32
@vrom911 vrom911 closed this Jul 6, 2023
@vrom911 vrom911 deleted the vrom911/80-multiple-errors branch July 6, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The pop-up window for errors doesn't contain proper error message
2 participants