Cairo: pass around the builtins pointer only when necessary #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
force-pushed
the
cairo-builtin-ptr
branch
from
34d838b
to
6f9eb4a
Compare
lukaszcz
force-pushed
the
cairo-builtin-ptr
branch
from
0ec6a2b
to
345500e
Compare
|
Implementing this is more time consuming than I thought, because it requires having two calling conventions: one for functions that need builtins and one for functions that do not. In closure calls, we would need to dynamically decide which one to use, or wrap functions on closure creation to use the convention with builtins. I defer this PR to 0.6.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress