-
Notifications
You must be signed in to change notification settings - Fork 58
tests: add first Unit tests #104
base: develop
Are you sure you want to change the base?
Conversation
@anitab-org/qa-team Can someone test this? Nothing should be broken but just to be safe :) Only login had some changes, so if that works everything else will work like before . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@techno-disaster All the tests are running as can be seen in the following screenshots 👍
and login functionality is also working fine :
shouldn't have pushed coverage 🤦 |
The current android test fails because we do not have the secret setup, will contact May on Zulip regarding this. |
uwu :) |
633df7e
Anyways i was able to fix this 🤦 wasn't thinking straight earlier i guess. Could you give it a quick review @bartekpacia @isabelcosta |
Are you doing the "run tests" step on GitHub Actions / TravisCI? @techno-disaster |
it's on travis @isabelcosta I know we have planned to move to GH actions, but can wr merge this first and move the CI/Cd in a different issue and PR? |
@bartekpacia could you review this? |
@anitab-org/mentorship-flutter-maintainers any update on this? I'm planning to write more tests today and send a PR, would like to see the new codecov bot working on it. |
I already approved @techno-disaster |
Status on hold, waiting for #117 to merge because bloc 6.0.1 has some breaking changes on bloc_test too. Once that gets merged I'll update this PR with bloc 6.0.1 too :) |
@techno-disaster can you fix the merge conflicts and then I can approve and call out for more reviewers to get this to the finish line |
done |
Codecov Report
@@ Coverage Diff @@
## develop #104 +/- ##
==========================================
Coverage ? 17.25%
==========================================
Files ? 25
Lines ? 284
Branches ? 0
==========================================
Hits ? 49
Misses ? 235
Partials ? 0 |
@techno-disaster where are you running these tests, in what github action? I don't see it. |
No, this is done on travis |
got it, found it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, but we need more reviews here, as I am not very well versed with Flutter. I also notice some inconsistencies in the folder names in the tests
folder. But its a minor issue perhaps for another issue.
Great to see test coverage increasing in this project :) 👏 @techno-disaster
@robotjellyzone can you please add a review to this again? |
Description
Units tests for flutter client :) . Not all atm tho, these tests are only for auth and login. Also added
flutter test
in the gitthub ci/cd to have unit tests on each PR and build. Finally this also integreate codecov.io with which we can keep a check on the current code coverage as shown below.Fixes #106
Flutter Channel:
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
Physical device,
flutter test
screenshot below.We also get a really good coverage for the part thats written, code conv screenshot below
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only