forked from Agoric/agoric-3-proposals
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request Agoric#186 from Agoric/pr-template
Create pull_request_template.md
- Loading branch information
Showing
1 changed file
with
29 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
<!-- | ||
Thank you for submitting a pull request! | ||
Please delete the sections below that aren pertinent to your PR | ||
and then fulfill the remaining checklist items before merging. | ||
--> | ||
|
||
Closes # | ||
|
||
# adopt a passed proposal | ||
When a proposal passes on agoric-3 Mainnet, it should be included in the history that this synthetic image tracks. | ||
|
||
- [ ] before this PR, change any `fromTag` using `latest` (such as [a3p-integration](https://github.com/Agoric/agoric-sdk/blob/master/a3p-integration/package.json)) to use a fixed version (otherwise they will fail when this PR changes latest and they pick it up) | ||
- [ ] before merging this PR, include a link to a PR that adopts its fromTag `use-${proposalName}` (where proposalName is the part of the agoric-3-proposals proposal directory name after the colon, cf. [a3p-integration/proposals](https://github.com/Agoric/agoric-sdk/tree/master/a3p-integration/proposals#how-to-revise-this-directory-after)) | ||
- [ ] after this PR merges, merge that other PR | ||
|
||
## image building process | ||
|
||
This should not affect other repos but be prepared that it might. | ||
|
||
## @agoric/synthetic-chain library | ||
These need to be published to be consumed in other apps. It's not yet on 1.0 so breaking changes are allowed, but please don't make them gratuitously. | ||
|
||
- [ ] indicate in the PR description when you expect these to be published and by whom (it's currently a manual process) | ||
|
||
## tooling improvements | ||
|
||
As long as it passes CI it should be fine. | ||
|