-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added custom loaders to nunjucks-template-engine #225
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
@WoMayr - thanks for the PR. My only concern is that this does not give an option to remove the default loader if one wanted to. I wonder if we could find a way to include the default in the |
This also came to my mind. But I didn't have any good idea on how to fix that. Maybe allow to either pass a factory method or directly the instance of the loader and use this to add the loaders like it is done with the filters and tags inside |
I don't think this PR as it stands is the approach we want to take. |
PR for Issue #224.