Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added custom loaders to nunjucks-template-engine #225

Closed
wants to merge 1 commit into from

Conversation

WoMayr
Copy link

@WoMayr WoMayr commented Jun 12, 2017

PR for Issue #224.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@WoMayr
Copy link
Author

WoMayr commented Jun 12, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@petebacondarwin
Copy link
Contributor

@WoMayr - thanks for the PR. My only concern is that this does not give an option to remove the default loader if one wanted to. I wonder if we could find a way to include the default in the loaders property? Given that the default loader needs access to the templateFinder.templateFolders for it to work, it might need to accept an array of factory functions?

@WoMayr
Copy link
Author

WoMayr commented Jun 12, 2017

This also came to my mind. But I didn't have any good idea on how to fix that.

Maybe allow to either pass a factory method or directly the instance of the loader and use this to add the loaders like it is done with the filters and tags inside /nunjucks/index.js.
But I have no idea how the dependency injection works to call the factory method with the wanted parameters.

@petebacondarwin
Copy link
Contributor

I don't think this PR as it stands is the approach we want to take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants