fix(@angular-devkit/build-angular): replace istanbul-instrumenter-loa…

…der with coverage-istanbul-loader Fixes #16576 and fixes #7117
angular · Jan 9, 2020 · 653be11 · 653be11
1 parent 4b17667
commit 653be11
Show file tree

Hide file tree

Showing 3 changed files with 49 additions and 160 deletions.
diff --git a/packages/angular_devkit/build_angular/package.json b/packages/angular_devkit/build_angular/package.json
@@ -23,12 +23,12 @@
     "caniuse-lite": "1.0.30001019",
     "circular-dependency-plugin": "5.2.0",
     "clean-css": "4.2.1",
+    "coverage-istanbul-loader": "2.0.3",
     "copy-webpack-plugin": "5.1.1",
     "core-js": "3.6.2",
     "file-loader": "5.0.2",
     "find-cache-dir": "3.2.0",
     "glob": "7.1.6",
-    "istanbul-instrumenter-loader": "3.0.1",
     "jest-worker": "24.9.0",
     "karma-source-map-support": "1.4.0",
     "less": "3.10.3",

diff --git a/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/test.ts b/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/test.ts
@@ -20,7 +20,6 @@ export function getTestConfig(
   const extraRules: webpack.Rule[] = [];
   const extraPlugins: webpack.Plugin[] = [];
 
-  // if (buildOptions.codeCoverage && CliConfig.fromProject()) {
   if (buildOptions.codeCoverage) {
     const codeCoverageExclude = buildOptions.codeCoverageExclude;
     const exclude: (string | RegExp)[] = [
@@ -39,7 +38,7 @@ export function getTestConfig(
 
     extraRules.push({
       test: /\.(jsx?|tsx?)$/,
-      loader: require.resolve('istanbul-instrumenter-loader'),
+      loader: require.resolve('coverage-istanbul-loader'),
       options: { esModules: true },
       enforce: 'post',
       exclude,