-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure memory efficiency when working with peak images #25
Open
alex-l-kong
wants to merge
17
commits into
main
Choose a base branch
from
optimize_peak_img
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…atch changes to workflow
Pull Request Test Coverage Report for Build 12037261796Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
With 1000+ peak images, keeping them all stored in memory is infeasible. They should be saved and loaded in on an individual basis.
How did you implement your changes
This will change the peak image workflow. Currently, they're all housed in a single in-memory
xarray
. Instead:extraction.coordinate_integration
, save the peak images directly instead of storing them in thexarray
. This will replace the functionality inplotting.save_peak_images
plotting.plot_peak_hist
to replace the notebook cellimage_data.sel(peak=[desired_peak_hist], method="nearest").plot.hist(bins=bin_count)
extraction.library_matching
to useio_utils.list_files
to retrieve the peak values instead of using thexarray
dimensionplotting.save_matched_peak_images
to load the matched peak image fromextraction_dir
instead of indexing into thexarray
directlyRemaining issues
Ongoing testing, full testing suite still needs to be implemented.