Generate Lines in chart.html Using Default Data #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11
commented
Dec 17, 2020
| p.line(self.data['date'], self.account.equity, color='#49516F', legend='Strategy') | ||
| base_equity = [price*shares for price in self.data['open']] | ||
| p.line(pd.to_datetime(self.data['date']), base_equity, color='#CAD8DE', legend='Buy and Hold') | ||
| p.line(pd.to_datetime(self.data['date']), self.account.equity, color='#49516F', legend='Strategy') |
There was a problem hiding this comment.
@anfederico I removed some unwanted whitespace in this file -- but line 129 & 130 is the main hack I used to get your example data to work
11
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No lines were rendered inside
chart.htmlafter runningbacktest.chart()on your example backtest algorithm andBTCUSDdataI'm not exactly sure if the issue I'm running into is an error, or if just the example data included in this repo requires updating - but as mentioned here in your README:
it could just be that the data was formatted incorrectly
Github Issue
this open issue
Changes
The pandas dates that were stored inside the
self.data['date']object needed to be converted from strings todatetimeobjects usingpd.to_datetime(self.data['date'])How to Replicate
This was the guide I was following:
https://gemini-docs.readthedocs.io/en/latest/using-gemini.html#basic
This was the data I used:
https://github.com/anfederico/gemini/blob/master/examples/data/BTC_USD.csv
This is the HTML that was generated into chart.html:
https://gist.github.com/11/159820cdf0a7b8dd69bd928add991acd
Screenshots
Broken version of
backtest.charts()Updated version
