feat: Add environment variables for dynamic object storage #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemaitre-aneo
force-pushed
the
fl/dynamic-object-storage
branch
2 times, most recently
from
fd92f91 to
3658b57
Compare
lemaitre-aneo
force-pushed
the
fl/dynamic-object-storage
branch
from
3658b57 to
f845d82
Compare
tschneider-aneo
approved these changes
Dec 27, 2024
jordancarrier
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In branch main of ArmoniK.Core, the object storage is now dynamic and requires new environment variables to work.
Description
Adds the environment variables related to the dynamic loading of the object storage to the output of the storage modules.
Testing
This has been tested on AWS using the latest ArmoniK.Core snapshot (0.30.0-SNAPSHOT.18.220164cc)
Checklist