fix: set readiness check to degraded when pollster does not process t…

…asks (#695)
aneoconsulting · Apr 23, 2024 · 556fcb8 · 556fcb8
2 parents c2e1091 + a4b0aed
commit 556fcb8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/Common/src/Pollster/Pollster.cs b/Common/src/Pollster/Pollster.cs
@@ -241,6 +241,11 @@ public async Task<HealthCheckResult> Check(HealthCheckTag tag)
       healthCheckFailedResult_ = result;
     }
 
+    if (tag == HealthCheckTag.Readiness && taskProcessingDict_.IsEmpty)
+    {
+      return HealthCheckResult.Unhealthy("No tasks to process");
+    }
+
     return result;
   }
 

diff --git a/Common/tests/Pollster/PollsterTest.cs b/Common/tests/Pollster/PollsterTest.cs
@@ -297,7 +297,8 @@ await testServiceProvider.Pollster.Init(CancellationToken.None)
     Assert.AreEqual(HealthStatus.Healthy,
                     (await testServiceProvider.Pollster.Check(HealthCheckTag.Liveness)
                                               .ConfigureAwait(false)).Status);
-    Assert.AreEqual(HealthStatus.Healthy,
+    // Unhealthy because there are no tasks in queue
+    Assert.AreEqual(HealthStatus.Unhealthy,
                     (await testServiceProvider.Pollster.Check(HealthCheckTag.Readiness)
                                               .ConfigureAwait(false)).Status);
     Assert.AreEqual(HealthStatus.Healthy,