feat: architecture armonik extension development #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aneojgurhem
reviewed
May 31, 2024
aneojgurhem
reviewed
May 31, 2024
There was a problem hiding this comment.
This AEP is a bit short compared to all the sections from our list of sections. As it describes our high level sdk, it is not really linked to our model.
I expect some of the following subjects to be addressed:
- Not rely too much on C#. (especially some namings)
- Some examples to show how it is expected to be used. How do I define a task ? How am I expected to get my output ?
- What is a task ? a result ?
- ResultService should not appear as we want to rename to BlobService or some other thing with a clearer meaning.
- How do I monitor things ? What can I know and how ?
- Worker side has not been adressed yet (I now it is not for now) but I would expect a few words about it.
- SDKs should provide ways to easily define ArmoniK based applications (client and worker side). I think this should appear in the abstract and motivation parts. Why do we want that should appear too.
AEP/aep-00004.md
Outdated
|
|
||
| This AEP aims to create a standard architecture for ArmoniK's extension development. It proposes services decoupling, segregating interfaces to related domains, and enriching domains. | ||
|
|
||
| # Proposed Solution |
There was a problem hiding this comment.
Proposed Solution is not a section available in our template. See AEP1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.