Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor scripts/dynamics/extract_renewal_events.py #183

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Refactor scripts/dynamics/extract_renewal_events.py #183

merged 5 commits into from
Oct 23, 2023

Conversation

andthum
Copy link
Owner

@andthum andthum commented Oct 23, 2023

Refactor scripts/dynamics/extract_renewal_events.py

Type of change

  • Change of core package.
  • Change of scripts.
  • Bug fix.
  • New feature.
  • Code refactoring.
  • Dependency update.
  • Documentation update.
  • Maintenance.
  • Other: Description.
  • Non-breaking (backward-compatible) change.
  • Breaking (non-backward-compatible) change.

Proposed changes

scripts/dynamics/extract_renewal_events.py:

  • Do some minor code refactoring
  • Write module docstring.
  • Format code, comments and existing docstrings.

PR checklist

  • I followed the guidelines in the Developer's guide.
  • New/changed code is properly tested.
  • New/changed code is properly documented.
  • The CI workflow is passing.

@andthum
[extract_renewal_events.py]: Refactor and Format
5d1b879 
* Minor code refactoring.
* Write module docstring.
* Format code, docstrings and comments.
@andthum
[discrete_coord.py]: Fix Wrong Docstring
8c42f63
@andthum
[dynamics.rst]: Add extract_renewal_events
050ae3a 
Add the docstring of the script
`scripts/dynamics/extract_renewal_events.py` to the official MDTools
documentation.
@andthum
[tests.yml]: black: Check extract_renewal_events
eb944f3 
Check the format of the script
`scripts/dynamics/extract_renewal_events.py` with black during the CI
workflow.
@andthum
[settings.json]: cSpell: Extend List of Ignored Words
1da9b00
@github-actions github-actions bot added documentation Improvements or additions to documentation patch Change that results in a new patch version refactoring Code refactoring labels Oct 23, 2023
@andthum andthum merged commit 38a9dc0 into main Oct 23, 2023
33 checks passed
@andthum andthum deleted the ref/scripts/dynamics/extract-renewal-events branch October 23, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation patch Change that results in a new patch version refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andthum