Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support namespaces #583

Merged
merged 11 commits into from
Dec 22, 2024
Merged

WIP: Support namespaces #583

merged 11 commits into from
Dec 22, 2024

Conversation

andrzejressel
Copy link
Owner

@andrzejressel andrzejressel commented Dec 20, 2024

Fixes #578

@andrzejressel andrzejressel changed the title Draft: Support namespaces WIP: Support namespaces Dec 20, 2024
Copy link
Contributor

mergify bot commented Dec 20, 2024

This pull request is marked as WIP and cannot be merged. Please remove 'WIP' from the title to proceed.

@andrzejressel andrzejressel marked this pull request as draft December 21, 2024 16:09
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.72%. Comparing base (e45055e) to head (2800a4b).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   83.21%   83.72%   +0.51%     
==========================================
  Files          31       35       +4     
  Lines        3794     3698      -96     
==========================================
- Hits         3157     3096      -61     
+ Misses        637      602      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +12 to +13
let result = crate::bindings::pulumi::typesystem::deep_nested_module_some_function::invoke(
);

Check warning

Code scanning / clippy

this let-binding has unit value Warning

this let-binding has unit value
pub fn invoke(
) -> SomeFunctionResult {

let result = crate::bindings::pulumi::typesystem::deep_nested_module_some_function::invoke(

Check warning

Code scanning / clippy

unused variable: result Warning

unused variable: result
}

#[derive(Serialize)]
struct AliasType {

Check warning

Code scanning / clippy

struct AliasType is never constructed Warning

struct AliasType is never constructed
Comment on lines +20 to +25
let result = crate::bindings::pulumi::typesystem::deep_nested_module_some_resource::invoke(
name,
&crate::bindings::pulumi::typesystem::deep_nested_module_some_resource::Args {
string_input: &args.string_input.get_inner(),
}
);

Check warning

Code scanning / clippy

this let-binding has unit value Warning

this let-binding has unit value
args: SomeResourceArgs
) -> SomeResourceResult {

let result = crate::bindings::pulumi::typesystem::deep_nested_module_some_resource::invoke(

Check warning

Code scanning / clippy

unused variable: result Warning

unused variable: result
Comment on lines +32 to +43
let result = crate::bindings::pulumi::typesystem::typesystem_server::invoke(
name,
&crate::bindings::pulumi::typesystem::typesystem_server::Args {
optional_string_array: &args.optional_string_array.get_inner(),
optional_string_input: &args.optional_string_input.get_inner(),
optional_union: &args.optional_union.get_inner(),
properties_collection: &args.properties_collection.get_inner(),
required_string_array: &args.required_string_array.get_inner(),
required_string_input: &args.required_string_input.get_inner(),
required_union: &args.required_union.get_inner(),
}
);

Check warning

Code scanning / clippy

this let-binding has unit value Warning

this let-binding has unit value
required_string_input: &args.required_string_input.get_inner(),
required_union: &args.required_union.get_inner(),
});
let result = crate::bindings::pulumi::typesystem::typesystem_server::invoke(

Check warning

Code scanning / clippy

unused variable: result Warning

unused variable: result
@@ -3,6 +3,7 @@
use convert_case::Case;
use convert_case::Case::UpperCamel;
use convert_case::Casing;
use itertools::Itertools;

Check warning

Code scanning / clippy

unused import: itertools::Itertools Warning

unused import: itertools::Itertools
@andrzejressel andrzejressel added the ready-to-merge Will be auto-merged by mergify label Dec 22, 2024
@andrzejressel andrzejressel marked this pull request as ready for review December 22, 2024 02:32
@mergify mergify bot merged commit ef13e21 into main Dec 22, 2024
11 checks passed
@mergify mergify bot deleted the namespaces branch December 22, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Will be auto-merged by mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for namespaces
2 participants