Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite deserialization #581

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

andrzejressel
Copy link
Owner

No description provided.

@andrzejressel andrzejressel changed the title Rewrite deserialization WIP: Rewrite deserialization Dec 19, 2024
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.96%. Comparing base (f5a4681) to head (89d09ff).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pulumi_wasm_generator_lib/src/lib.rs 55.55% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
- Coverage   83.21%   82.96%   -0.25%     
==========================================
  Files          31       32       +1     
  Lines        3794     3840      +46     
==========================================
+ Hits         3157     3186      +29     
- Misses        637      654      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

mergify bot commented Dec 20, 2024

This pull request is marked as WIP and cannot be merged. Please remove 'WIP' from the title to proceed.

@andrzejressel andrzejressel marked this pull request as draft December 21, 2024 16:09
@andrzejressel andrzejressel changed the title WIP: Rewrite deserialization Rewrite deserialization Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants