Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oneof with String #569

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Fix oneof with String #569

merged 3 commits into from
Dec 15, 2024

Conversation

andrzejressel
Copy link
Owner

@andrzejressel andrzejressel commented Dec 15, 2024

Closes #563

@andrzejressel andrzejressel added the ready-to-merge Will be auto-merged by mergify label Dec 15, 2024
pulumi_wasm_generator_lib/src/model.rs Fixed Show fixed Hide fixed
pulumi_wasm_generator_lib/src/model.rs Fixed Show fixed Hide fixed
pulumi_wasm_generator_lib/src/model.rs Fixed Show fixed Hide fixed
pulumi_wasm_generator_lib/src/schema.rs Fixed Show fixed Hide fixed
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.54%. Comparing base (1cd7896) to head (c4d15c4).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pulumi_wasm_generator_lib/src/schema.rs 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   82.52%   82.54%   +0.02%     
==========================================
  Files          31       31              
  Lines        3554     3570      +16     
==========================================
+ Hits         2933     2947      +14     
- Misses        621      623       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit cd5f21f into main Dec 15, 2024
11 checks passed
@mergify mergify bot deleted the oneof_with_string branch December 15, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Will be auto-merged by mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support oneof with string + enum
2 participants