Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get functions #413

Merged
merged 22 commits into from
Sep 29, 2024
Merged

Get functions #413

merged 22 commits into from
Sep 29, 2024

Conversation

andrzejressel
Copy link
Owner

Closes #340

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@andrzejressel andrzejressel changed the title WIP: Get functions Get functions Sep 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 34.96503% with 93 lines in your changes missing coverage. Please review.

Project coverage is 71.58%. Comparing base (da2e3eb) to head (f11bb2b).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pulumi_wasm_core/src/pulumi/service_impl.rs 0.00% 80 Missing ⚠️
pulumi_wasm_core/src/engine.rs 73.68% 10 Missing ⚠️
pulumi_wasm_core/src/nodes.rs 88.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   73.43%   71.58%   -1.85%     
==========================================
  Files           5        5              
  Lines        1404     1457      +53     
==========================================
+ Hits         1031     1043      +12     
- Misses        373      414      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrzejressel andrzejressel added the ready-to-merge Will be auto-merged by mergify label Sep 29, 2024
@andrzejressel
Copy link
Owner Author

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Sep 29, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 1a709bf into main Sep 29, 2024
11 checks passed
@mergify mergify bot deleted the get-functions branch September 29, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Will be auto-merged by mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement get functions
2 participants