Add HDR capture support #86
Conversation
calren
changed the title
calren
changed the title
|
@madebymozart this is ready for review now! |
| videoCapabilities.supportedDynamicRanges | ||
|
|
||
| supportedHdrEncoding = supportedDynamicRanges.firstOrNull { | ||
| it != DynamicRange.SDR // Ensure an HDR encoding is found |
There was a problem hiding this comment.
Why don't you directly check HDR, not SDR?
There was a problem hiding this comment.
+1 to this, can we just check if it is HDR instead?
There was a problem hiding this comment.
i'm not sure, i copied the code snippet from https://android-developers.googleblog.com/2023/06/camerax-13-is-now-in-beta.html which has the snippet:
supportedHdrEncoding = supportedDynamicRanges.firstOrNull {
it != DynamicRange.SDR // Ensure an HDR encoding is found
}
@donovanfm any idea why we are checking for NOT SDR instead of checking for HDR directly?
| videoCapabilities.supportedDynamicRanges | ||
|
|
||
| supportedHdrEncoding = supportedDynamicRanges.firstOrNull { | ||
| it != DynamicRange.SDR // Ensure an HDR encoding is found |
There was a problem hiding this comment.
Can we actually make this more specific as well?
There seem to be multiple different dynamic range profiles and to make it consistent, we should choose one we know they all support, which would be HLG 10-bit
https://developer.android.com/reference/androidx/camera/core/DynamicRange
Any device that supports HDR should support HLG 10-bit at a minimum
| private var currentRecording: Recording? = null | ||
| private lateinit var recordingState: VideoRecordEvent | ||
|
|
||
| init { | ||
| val videoCaptureBuilder = VideoCapture.Builder(recorder) | ||
|
|
There was a problem hiding this comment.
nit: any reason for the space here?
There was a problem hiding this comment.
i think just habit for personal preference for code readability, but removed
|
updated based on feedback. @madebymozart can you take another look? thanks! |
Non-HDR video captured without changes in this PR
https://github.com/user-attachments/assets/5977f46c-a375-4b89-b15e-a3cd27f1c508
HDR video captured with changes in this PR
https://github.com/user-attachments/assets/97c513cc-25af-4c87-afd1-2654518a8f52