-
Notifications
You must be signed in to change notification settings - Fork 305
Support KMS Encryption #166
base: master
Are you sure you want to change the base?
Conversation
jeremygaither
commented
Mar 3, 2017
- Add extra parameters for Metadata and supporting AWS KMS
- Remove ETag comparisons for KMS, as KMS ETag is no longer MD5 of plaintext file: http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingKMSEncryption.html
* ETags do not match when using KMS, by design. See http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingKMSEncryption.html
* ETags do not match when using KMS, by design. See http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingKMSEncryption.html
If you want this merged & published to npm, submit the PR to: https://github.com/faceleg/node-s3-client |
@jeremygaither Would you be able to submit this pull request to one of the active forks of the project, e.g., https://github.com/faceleg/node-s3-client? I am using AWS server-side encryption and it would be really useful if your fix was present in NPM. |
@octachrome I'll need to re-test against the latest upstream... |
Removed illegal parameters from Upload Part call
Hi there. Where is this at? |
Rather than suppress integrity checking, it's worth considering calculating the 128-bit MD5 digest of the file (or part if multipart) before upload. Include the base64-encoded value in the |
@john-aws I believe the problem was that the md5 of the clear text chunk did not match the value returned by S3. But honestly, it's been years since I used this library. I haven't used this patch since a few months after I initially created it. Plus, I think this repo is unmaintained, and another fork is being used to push to NPM. I'm not completely sure about that though. |