Skip to content
This repository has been archived by the owner on Feb 12, 2021. It is now read-only.

Support KMS Encryption #166

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jeremygaither
Copy link

@faceleg
Copy link
Contributor

faceleg commented Mar 4, 2017

If you want this merged & published to npm, submit the PR to: https://github.com/faceleg/node-s3-client

@OmgImAlexis OmgImAlexis modified the milestone: Backlog Aug 19, 2017
@octachrome
Copy link

@jeremygaither Would you be able to submit this pull request to one of the active forks of the project, e.g., https://github.com/faceleg/node-s3-client? I am using AWS server-side encryption and it would be really useful if your fix was present in NPM.

@jeremygaither
Copy link
Author

@octachrome I'll need to re-test against the latest upstream...

@nickbas
Copy link

nickbas commented Feb 4, 2019

Hi there. Where is this at?

@john-aws
Copy link

Rather than suppress integrity checking, it's worth considering calculating the 128-bit MD5 digest of the file (or part if multipart) before upload. Include the base64-encoded value in the Content-MD5 header. S3 will verify that the uploaded data matches and reject the object (or part) as needed.

@jeremygaither
Copy link
Author

@john-aws I believe the problem was that the md5 of the clear text chunk did not match the value returned by S3. But honestly, it's been years since I used this library. I haven't used this patch since a few months after I initially created it. Plus, I think this repo is unmaintained, and another fork is being used to push to NPM. I'm not completely sure about that though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants