Check for updates only once (#71)

* Fix update view padding and size

* Check for updates only once

* Lint

* Set current version before integration tests

* Improve build time

* Lint

Co-authored-by: andrea-vinci <[email protected]>

gradle.properties

@@ -1,2 +1,4 @@
 org.gradle.parallel=true
-org.gradle.jvmargs=-Xmx4096m -XX:MaxMetaspaceSize=512m
+org.gradle.jvmargs=-Xmx4g -XX:MaxMetaspaceSize=512m
+org.gradle.caching=true
+kotlin.incremental=true

src/integrationTest/kotlin/insulator/integrationtest/helper/KotestConfig.kt

@@ -0,0 +1,28 @@
+package insulator.integrationtest.helper
+
+import insulator.di.CONFIG_FILE_NAME
+import io.kotest.core.config.AbstractProjectConfig
+import io.kotest.core.test.TestCaseOrder
+import java.net.URLDecoder
+import java.nio.file.Paths
+
+object KotestConfig : AbstractProjectConfig() {
+
+    override val parallelism = 1
+    override val testCaseOrder = TestCaseOrder.Random
+
+    override fun beforeAll() {
+        mockCurrentAppVersion("999.999.999")
+        super.beforeAll()
+    }
+
+    fun mockCurrentAppVersion(version: String) {
+        val jarPath = Paths.get(this::class.java.protectionDomain.codeSource.location.toURI()).toString()
+        val jarFolder = Paths.get(URLDecoder.decode(jarPath, "UTF-8")).parent.toAbsolutePath().toString()
+        val configPath =
+            with(Paths.get(jarFolder, CONFIG_FILE_NAME).toAbsolutePath().toFile()) {
+                createNewFile()
+                writeText("app.version=$version")
+            }
+    }
+}

src/main/kotlin/insulator/lib/update/VersionChecker.kt

@@ -30,7 +30,7 @@ class VersionChecker(private val customJarPath: String? = null) {
         get() = customJarPath ?: Paths.get(this::class.java.protectionDomain.codeSource.location.toURI()).toString()
 
     fun getCurrentVersion() = Either.fx<Throwable, Version> {
-        val appVersion = !getAppVersion()
+        val appVersion = getAppVersion().fold({ "0.0.0" }, { it })
         val latestVersion = !getLatestVersion()
         val isANewVersionAvailable = Semver(appVersion).isLowerThan(latestVersion.version)
         Version(appVersion, if (isANewVersionAvailable) latestVersion else null)

src/main/kotlin/insulator/styles/Controls.kt

@@ -11,7 +11,7 @@ import tornadofx.multi
 import tornadofx.px
 
 class Controls : Stylesheet() {
-    private val defaultPadding = 15.0.px
+    private val defaultPadding = 12.0.px
 
     companion object {
 

src/main/kotlin/insulator/views/configurations/ListClusterView.kt

@@ -20,6 +20,7 @@ import javafx.scene.layout.BorderPane
 import javafx.stage.Modality
 import javafx.stage.StageStyle
 import tornadofx.* // ktlint-disable no-wildcard-imports
+import java.util.concurrent.atomic.AtomicBoolean
 
 class ListClusterView : InsulatorView<ListClusterViewModel>("Insulator", ListClusterViewModel::class) {
 
@@ -80,12 +81,19 @@ class ListClusterView : InsulatorView<ListClusterViewModel>("Insulator", ListClu
         checkVersion()
     }
 
-    private fun checkVersion() = VersionChecker().getCurrentVersion().map {
-        if (it.latestRelease != null) UpdateInfoView(it.latestRelease).customOpenWindow()
+    private fun checkVersion() {
+        if (wasVersionChecked.compareAndSet(false, true))
+            VersionChecker().getCurrentVersion().map {
+                if (it.latestRelease != null) UpdateInfoView(it.latestRelease).customOpenWindow(modality = Modality.WINDOW_MODAL)
+            }
     }
 
     override fun onError(throwable: Throwable) {
         // we can't continue without the list of clusters
         close()
     }
+
+    companion object {
+        private val wasVersionChecked = AtomicBoolean(false)
+    }
 }

src/main/kotlin/insulator/views/update/UpdateInfoView.kt

@@ -1,6 +1,7 @@
 package insulator.views.update
 
 import insulator.lib.update.Release
+import insulator.styles.Controls
 import insulator.styles.Titles
 import javafx.geometry.Pos
 import tornadofx.* // ktlint-disable no-wildcard-imports
@@ -21,13 +22,13 @@ class UpdateInfoView(release: Release) : View() {
         bottom = hbox(alignment = Pos.CENTER) {
             button("Close") { action { close() } }
         }
-        paddingAll = 20.0
+        addClass(Controls.view)
     }
 
     override fun onDock() {
         super.currentStage?.resizableProperty()?.set(false)
-        super.currentStage?.height = 300.0
-        super.currentStage?.width = 350.0
+        super.currentStage?.height = 350.0
+        super.currentStage?.width = 400.0
         super.onDock()
     }
 }

src/test/kotlin/helper/KotestConfig.kt

@@ -0,0 +1,9 @@
+package helper
+
+import io.kotest.core.config.AbstractProjectConfig
+import io.kotest.core.test.TestCaseOrder
+
+object KotestConfig : AbstractProjectConfig() {
+    override val parallelism = 1
+    override val testCaseOrder = TestCaseOrder.Random
+}