Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: graphql based authentication/authorization #403

Merged
merged 15 commits into from
Jul 3, 2024

Conversation

andrew-codes
Copy link
Owner

@andrew-codes andrew-codes commented Jul 3, 2024

Signing in/out now handled by GraphQL /api endpoint. GraphQL endpoint reads an authorization cookie for subsequent graph requests. Both a cookie and HTTP header of authorization: Bearer $token are accepted.

Relates to #318

BREAKING CHANGE: /activate endpoint has been removed. This will be replaced by a GraphQL endpoint.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 152 lines in your changes missing coverage. Please review.

Project coverage is 6.71%. Comparing base (b25b77c) to head (bc21105).
Report is 1 commits behind head on main.

Files Patch % Lines
...e-web/src/server/graphql/modules/auth/api/index.ts 0.00% 32 Missing and 3 partials ⚠️
...web/src/server/graphql/modules/user/api/getUser.ts 0.00% 19 Missing ⚠️
.../graphql/modules/auth/resolvers/Mutation/signIn.ts 0.00% 16 Missing ⚠️
apps/playnite-web/src/server/graphql/index.ts 0.00% 10 Missing and 3 partials ⚠️
apps/playnite-web/src/queryHooks/signIn.ts 0.00% 11 Missing ⚠️
apps/playnite-web/src/server/graphql/Domain.ts 0.00% 11 Missing ⚠️
apps/playnite-web/src/queryHooks/signOut.ts 0.00% 9 Missing ⚠️
...graphql/modules/auth/resolvers/Mutation/signOut.ts 0.00% 8 Missing ⚠️
.../server/graphql/modules/user/resolvers/Query/me.ts 0.00% 7 Missing ⚠️
apps/playnite-web/src/queryHooks/me.ts 0.00% 5 Missing ⚠️
... and 7 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #403      +/-   ##
========================================
- Coverage   7.46%   6.71%   -0.75%     
========================================
  Files         50      62      +12     
  Lines       1005    1087      +82     
  Branches     166     179      +13     
========================================
- Hits          75      73       -2     
- Misses       896     976      +80     
- Partials      34      38       +4     
Flag Coverage Δ
component-tests 14.03% <ø> (ø)
unit-tests 5.85% <0.00%> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrew-codes andrew-codes merged commit 5c60ca4 into main Jul 3, 2024
9 of 11 checks passed
Copy link

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

4 similar comments
Copy link

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant