fix: floation point rounding issue

Change `getValueFromPosition` value calculation. The `+ this.min` needs to be outside, otherwise it gets the wrong answer unless `this.min` is divisible by this.step. Big ups to @jpmckinney Closes issue #50, #91
andreruffert · Sep 28, 2014 · 94c5f74 · 94c5f74
1 parent 8df30fb
commit 94c5f74
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/dist/rangeslider.js b/dist/rangeslider.js
@@ -264,7 +264,7 @@
     Plugin.prototype.getValueFromPosition = function(pos) {
         var percentage, value;
         percentage = ((pos) / (this.maxHandleX || 1));
-        value = this.step * Math.ceil((((percentage) * (this.max - this.min)) + this.min) / this.step);
+        value = this.step * Math.round(percentage * (this.max - this.min) / this.step) + this.min;
         return Number((value).toFixed(2));
     };
 

diff --git a/dist/rangeslider.min.js b/dist/rangeslider.min.js
diff --git a/src/rangeslider.js b/src/rangeslider.js
@@ -263,7 +263,7 @@
     Plugin.prototype.getValueFromPosition = function(pos) {
         var percentage, value;
         percentage = ((pos) / (this.maxHandleX || 1));
-        value = this.step * Math.ceil((((percentage) * (this.max - this.min)) + this.min) / this.step);
+        value = this.step * Math.round(percentage * (this.max - this.min) / this.step) + this.min;
         return Number((value).toFixed(2));
     };