fix: getRelativePosition use clientX/clientY instead of pageX/pageY

close #236 close #238 close #239 Bug introduced in 53fa2d1
andreruffert · Nov 30, 2016 · 5d295c5 · 5d295c5
1 parent e56430a
commit 5d295c5
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 15 deletions.
diff --git a/dist/rangeslider.js b/dist/rangeslider.js
@@ -402,15 +402,16 @@
             rangePos = this.$range[0].getBoundingClientRect()[this.DIRECTION],
             pageCoordinate = 0;
 
-        if (typeof e['page' + ucCoordinate] !== 'undefined') {
-            pageCoordinate = e['page' + ucCoordinate];
-        }
-        // IE8 support :)
-        else if (typeof e.originalEvent['client' + ucCoordinate] !== 'undefined') {
+        if (typeof e.originalEvent['client' + ucCoordinate] !== 'undefined') {
+            console.log('client' + ucCoordinate);
             pageCoordinate = e.originalEvent['client' + ucCoordinate];
         }
-        else if (e.originalEvent.touches && e.originalEvent.touches[0] && typeof e.originalEvent.touches[0]['page' + ucCoordinate] !== 'undefined') {
-            pageCoordinate = e.originalEvent.touches[0]['page' + ucCoordinate];
+        else if (
+          e.originalEvent.touches &&
+          e.originalEvent.touches[0] &&
+          typeof e.originalEvent.touches[0]['client' + ucCoordinate] !== 'undefined'
+        ) {
+            pageCoordinate = e.originalEvent.touches[0]['client' + ucCoordinate];
         }
         else if(e.currentPoint && typeof e.currentPoint[this.COORDINATE] !== 'undefined') {
             pageCoordinate = e.currentPoint[this.COORDINATE];

diff --git a/dist/rangeslider.min.js b/dist/rangeslider.min.js
diff --git a/src/rangeslider.js b/src/rangeslider.js
@@ -401,15 +401,16 @@
             rangePos = this.$range[0].getBoundingClientRect()[this.DIRECTION],
             pageCoordinate = 0;
 
-        if (typeof e['page' + ucCoordinate] !== 'undefined') {
-            pageCoordinate = e['page' + ucCoordinate];
-        }
-        // IE8 support :)
-        else if (typeof e.originalEvent['client' + ucCoordinate] !== 'undefined') {
+        if (typeof e.originalEvent['client' + ucCoordinate] !== 'undefined') {
+            console.log('client' + ucCoordinate);
             pageCoordinate = e.originalEvent['client' + ucCoordinate];
         }
-        else if (e.originalEvent.touches && e.originalEvent.touches[0] && typeof e.originalEvent.touches[0]['page' + ucCoordinate] !== 'undefined') {
-            pageCoordinate = e.originalEvent.touches[0]['page' + ucCoordinate];
+        else if (
+          e.originalEvent.touches &&
+          e.originalEvent.touches[0] &&
+          typeof e.originalEvent.touches[0]['client' + ucCoordinate] !== 'undefined'
+        ) {
+            pageCoordinate = e.originalEvent.touches[0]['client' + ucCoordinate];
         }
         else if(e.currentPoint && typeof e.currentPoint[this.COORDINATE] !== 'undefined') {
             pageCoordinate = e.currentPoint[this.COORDINATE];