fix: set initial value if no value attribute is set

#183
andreruffert · Nov 15, 2015 · 3f5c475 · 3f5c475
1 parent 9c1b171
commit 3f5c475
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 13 deletions.
diff --git a/dist/rangeslider.js b/dist/rangeslider.js
@@ -279,10 +279,6 @@
     Plugin.prototype.init = function() {
         this.update(true, false);
 
-        // Set initial value just in case it is not set already.
-        // Prevents trouble if we call `update(true)`
-        this.$element[0].value = this.value;
-
         if (this.onInit && typeof this.onInit === 'function') {
             this.onInit();
         }
@@ -294,7 +290,7 @@
         if (updateAttributes) {
             this.min    = tryParseFloat(this.$element[0].getAttribute('min'), 0);
             this.max    = tryParseFloat(this.$element[0].getAttribute('max'), 100);
-            this.value  = tryParseFloat(this.$element[0].value, this.min + (this.max-this.min)/2);
+            this.value  = tryParseFloat(this.$element[0].value, Math.round(this.min + (this.max-this.min)/2));
             this.step   = tryParseFloat(this.$element[0].getAttribute('step'), 1);
         }
 
@@ -433,7 +429,7 @@
     };
 
     Plugin.prototype.setValue = function(value) {
-        if (value === this.value) {
+        if (value === this.value && this.$element[0].value !== '') {
             return;
         }
 

diff --git a/dist/rangeslider.min.js b/dist/rangeslider.min.js
diff --git a/src/rangeslider.js b/src/rangeslider.js
@@ -278,10 +278,6 @@
     Plugin.prototype.init = function() {
         this.update(true, false);
 
-        // Set initial value just in case it is not set already.
-        // Prevents trouble if we call `update(true)`
-        this.$element[0].value = this.value;
-
         if (this.onInit && typeof this.onInit === 'function') {
             this.onInit();
         }
@@ -293,7 +289,7 @@
         if (updateAttributes) {
             this.min    = tryParseFloat(this.$element[0].getAttribute('min'), 0);
             this.max    = tryParseFloat(this.$element[0].getAttribute('max'), 100);
-            this.value  = tryParseFloat(this.$element[0].value, this.min + (this.max-this.min)/2);
+            this.value  = tryParseFloat(this.$element[0].value, Math.round(this.min + (this.max-this.min)/2));
             this.step   = tryParseFloat(this.$element[0].getAttribute('step'), 1);
         }
 
@@ -432,7 +428,7 @@
     };
 
     Plugin.prototype.setValue = function(value) {
-        if (value === this.value) {
+        if (value === this.value && this.$element[0].value !== '') {
             return;
         }