Allow setting a custom dir to pull the clang includes from #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${CLANG_INSTALL_PREFIX}/lib/clang/${LLVM_VERSION_MAJOR}/include
is invalid on systems that store the libs for clang seperately from whereverCLANG_INSTALL_PREFIX
is.E.g. on Nix/NixOS it points to
/nix/store/0y99g3631mcl08ym46a5803g0hr4rc8j-clang-16.0.6
which looks like:but also
/nix/store/l92dv1igdpgkb1mxjv9rabvk795k45ih-clang-16.0.6-lib
which looks like:Using a define for this directory lets me overwrite the value like so:
https://github.com/expenses/babble-nix/blob/b5ecce0864ccdad936adadd6514faf26fe8e93f8/package.nix#L14-L16
I'm happy to bikeshed on the naming of this variable.