-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package dependency completness field #3402
base: main
Are you sure you want to change the base?
Conversation
bb1b51b
to
141d19a
Compare
Signed-off-by: Alex Goodman <[email protected]>
141d19a
to
17abccb
Compare
@wagoodman I wanted to make sure I understand why the It seems like as we make a set of dependency relationships more complete, it passes from complete, to mixed, and back to complete, which is surprising:
It seems weird to me that a cataloger can effectively get promoted from complete to mixed, and then from mixed to complete, by adding relationship data. When I first read the descriptions above, I thought, "rust isn't complete, it's mixed, because it includes transitive dependencies." Am I understanding correctly here? |
Here each node in the cargo.lock is describing only direct dependencies so this is |
Signed-off-by: Alex Goodman <[email protected]>
17abccb
to
ad2abfa
Compare
Cross posting #3010 (comment) so that it gets seen here. |
Signed-off-by: Alex Goodman <[email protected]>
Description
Adds a field that describes the completeness of a package's direct dependencies:
complete
: the package has all of its direct dependencies resolved and related to this package.incomplete
: the package does not have all of its direct dependencies resolved.complete-with-indirect
: a superset ofcomplete
-- indicates that the package has all of its direct dependencies resolved as well as some or all of indirect dependencies. What is notable about this is that direct and indirect dependencies are linked directly to this package and are not separable (you cannot distinguish between a direct and indirect dependency from the perspective of this package).unknown
: indicates when dependency resolution mechanism for this package is not well understood.In addition to adding this new field, all catalogers were updated to raise up accurate values for this field:
Type of change
Checklist: