-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yardstick labels symlink to gitignore #151
Conversation
Signed-off-by: Alex Goodman <[email protected]>
056193c
to
8dd005d
Compare
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
It looks like the v1 and v2 schemas will not pass validation. A further look shows that this is mainly due to the fact that RPMs at these grype versions did not have epoch captured, thus the labels are not matching appropriately. Adding labels for these matches is not the right thing to do since they would not be accurate. Adding an exception to not validate the v1 and v2 DBs also isn't a good idea since we still want to protect against possible publishing issues. We could bump the gate configuration, however this will apply to all images for all DB schemas. This last approach is the lesser of all evils, so I'll make that update here, but ultimately we need to drop support for v1 and v2 schemas in the near future (which was always the plan). |
Signed-off-by: Alex Goodman <[email protected]>
Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.2.2 to 7.3.1. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@7.2.2...7.3.1) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
A few changes were made in this PR:
More on the gitignore change...
This is not valid:
Tip of the hat to https://stackoverflow.com/questions/3203228/git-ignore-exception/72380673#72380673 on this one.
When running the production run yesterday there were no relative comparison differences so the labels were not used. However, today there happened to be differences, so the labels were attempted to be used, but the link was not checked in, so it was as if there were no labels. The gate (correctly) failed since there were too many matches that were unlabeled.