Porting old gui elements to m2k #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreidanila1
requested review from
adisuciu,
AlexandraTrifan,
Andrei-Fabian-Pop,
IonutMuthi,
andrei47w and
bindea-cristian
andreidanila1
force-pushed
the
dev_gui2m2k
branch
from
801ef11
to
ca4247a
Compare
Signed-off-by: andrei.danila <[email protected]>
Signed-off-by: andrei.danila <[email protected]>
Signed-off-by: andrei.danila <[email protected]>
Sigrok-gui, gr-gui and m2k-gui. Signed-off-by: andrei.danila <[email protected]>
Signed-off-by: andrei.danila <[email protected]>
Signed-off-by: andrei.danila <[email protected]>
andreidanila1
force-pushed
the
dev_gui2m2k
branch
from
6969e4f
to
5520733
Compare
adisuciu
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved out from gui:
made OscScaleDraw as standalone class (renamed in BasicScaleDraw) - gui
made EdgelessPlot as standalone class - gui
used in tool_view and m2k tools
used in: logic_analyzer and pattern_generator
Used in: generic_menu
Used in m2k tools
we might have to implement other export and import classes
have to implement another version
Remained in gui:
Used in spibox_a, stylehelper and patterngenerator
Used in toolmenuitem
PlotWidget dependency but is never used
Move to m2k-gui?
Used in datalogger and regmap
Used in plotaxis and plotwidget
Must be renamed??
Re-implement them or not?