Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: scripts: Allow building with generated stm32 files instead of ioc #2367

Closed
wants to merge 1 commit into from

Conversation

CiprianRegus
Copy link
Contributor

Pull Request Description

Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

@buha
Copy link
Contributor

buha commented Nov 21, 2024

also, write the sequence of expected steps to build a project with this feature either in PR description or commit description


else

OPENOCD_SCRIPTS ?= /usr/share/openocd/scripts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this path does not exist on my machine, it's distro dependant, also most likely wont exist in Git Bash on windows

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also from what i understand you're trying to use a generic openocd here, ST has a fork of openocd https://github.com/STMicroelectronics/OpenOCD and the one that comes with the IDE is the forked one


ifeq ($(STM32_EXT_BUILD),y)

TARGET = $(shell echo $(CHIPNAME) | grep -Eo 'STM32[A-Z][0-9][0-9A-Z][0-9]')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why duplicate the pattern matching below ? this will need lots of effort to maintain

endif #STM32_EXT_BUILD

ifeq ($(STM32_EXT_BUILD),y)
$(PROJECT)_configure:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole _configure sequence shares a lot with the original sequence below, i don't think it's a good idea to duplicate it like this

@buha
Copy link
Contributor

buha commented Dec 2, 2024

closing for now, will be reopened

@buha buha closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants