Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation fault for no_os_uart fix #2366

Open
wants to merge 4 commits into
base: ftd2xx_ad74416h
Choose a base branch
from

Conversation

CAcarADI
Copy link

Pull Request Description

-Added Initialization for no_os_uart_init() function
-Added separate GPIO definitions.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

-Added Initialization for no_os_uart_init() function
-Added separate GPIO definitions.
@CLAassistant
Copy link

CLAassistant commented Nov 18, 2024

CLA assistant check
All committers have signed the CLA.

@CiprianRegus
Copy link
Contributor

The memory allocation is done in the platform specific driver (e.g https://github.com/analogdevicesinc/no-OS/blob/main/drivers/platform/maxim/max32650/maxim_uart.c#L258).

@CAcarADI
Copy link
Author

CAcarADI commented Nov 19, 2024

The memory allocation is done in the platform specific driver (e.g https://github.com/analogdevicesinc/no-OS/blob/main/drivers/platform/maxim/max32650/maxim_uart.c#L258).

Thanks for the reply, Ill try to initialize it on the platform driver and update my commit.

@CiprianRegus
Copy link
Contributor

Please squash the 2 commits and remove the changes done to the AD74416H project, as they seem unrelated. When implementing changes suggested by reviewers, you'll have to edit the original commit (git interactive rebase comes in handy for that) instead of creating a new one. Also the commits need a description and have to be signed.

Added Initialization of *desc in ftd2xx_uart_init() function

Signed-off-by: Christian Acar <[email protected]>
@CiprianRegus
Copy link
Contributor

Hi, the commits are still not squashed. Also, don't merge other branches into this one. Instead, rebase your branch on the one you want to merge into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants