-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmentation fault for no_os_uart fix #2366
base: ftd2xx_ad74416h
Are you sure you want to change the base?
Segmentation fault for no_os_uart fix #2366
Conversation
-Added Initialization for no_os_uart_init() function -Added separate GPIO definitions.
The memory allocation is done in the platform specific driver (e.g https://github.com/analogdevicesinc/no-OS/blob/main/drivers/platform/maxim/max32650/maxim_uart.c#L258). |
Thanks for the reply, Ill try to initialize it on the platform driver and update my commit. |
Please squash the 2 commits and remove the changes done to the AD74416H project, as they seem unrelated. When implementing changes suggested by reviewers, you'll have to edit the original commit (git interactive rebase comes in handy for that) instead of creating a new one. Also the commits need a description and have to be signed. |
Added Initialization of *desc in ftd2xx_uart_init() function Signed-off-by: Christian Acar <[email protected]>
556cc6b
to
1491e92
Compare
…nto ftd2xx_ad74416h
Hi, the commits are still not squashed. Also, don't merge other branches into this one. Instead, rebase your branch on the one you want to merge into. |
Pull Request Description
-Added Initialization for no_os_uart_init() function
-Added separate GPIO definitions.
PR Type
PR Checklist