Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move stark setup to dev container #54

Merged
merged 4 commits into from
Oct 22, 2024
Merged

chore: move stark setup to dev container #54

merged 4 commits into from
Oct 22, 2024

Conversation

jac18281828
Copy link
Contributor

@jac18281828 jac18281828 commented Oct 19, 2024 •
edited
Loading

closes #49

  1. this cleans up the stark setup
  2. fixes a few issues in the setup script with paths
  3. gets bonsol working in code space

@vercel Vercel
Copy link

vercel bot commented Oct 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bonsol ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 0:00am

@eureka-cpu
Copy link
Contributor

Some of the formatting options require nightly, to fix the failing check just run cargo +nightly fmt

eureka-cpu
eureka-cpu reviewed Oct 20, 2024
View reviewed changes
setup.sh Outdated Show resolved Hide resolved
@jac18281828
Copy link
Contributor Author

jac18281828 commented Oct 20, 2024 •
edited
Loading

Some of the formatting options require nightly, to fix the failing check just run cargo +nightly fmt

would there be any harm in just formatting it with stable?

btw - I already pushed the fix but just curious if +nightly is actually needed here

@jac18281828 jac18281828 self-assigned this Oct 21, 2024
@jac18281828 jac18281828 marked this pull request as ready for review October 21, 2024 14:50
@jac18281828 jac18281828 requested a review from austbot October 21, 2024 14:50
@jac18281828
Copy link
Contributor Author

Ready to go! Everything appears to build. I think we can move forward on this one

eureka-cpu
eureka-cpu approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@eureka-cpu eureka-cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jac18281828 jac18281828 merged commit d57f571 into main Oct 22, 2024
5 checks passed
@jac18281828 jac18281828 deleted the jac/version28 branch October 22, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eureka-cpu eureka-cpu eureka-cpu approved these changes

@austbot austbot Awaiting requested review from austbot

Assignees

@jac18281828 jac18281828

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add stark tools to devcontainer
2 participants
@jac18281828 @eureka-cpu