fix: Add optional S3 endpoint to upload arguments #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update introduces an optional `endpoint` field to the `S3UploadArgs` struct, allowing users to specify a custom AWS S3 compatibility endpoint. The deployment function has been modified to utilize this new endpoint if provided, otherwise defaulting to the standard S3 URL format. This enhances flexibility for users working with different S3-compatible services.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Nice one, looks good to me. Happy to approve once the CI checks pass. Also just a heads up, I'm working on a refactor for the CLI so it should be a bit more clear which args you actually need for what command etc. 🙂 |
eureka-cpu
reviewed
Dec 16, 2024
cli/src/deploy.rs
Outdated
| object_store::path::Path::from(format!("{}-{}", manifest.name, manifest.image_id)); | ||
|
|
||
| let url = if let Some(endpoint) = endpoint { | ||
| format!("{}", endpoint) |
There was a problem hiding this comment.
Since endpoint is already a String here I believe you can just return that instead of creating a new String with the format! macro
There was a problem hiding this comment.
For even more style points you could try (didn't test it but should be close):
let url = endpoint.unwrap_or(format!("https://{}.s3.{}.amazonaws.com/{}", bucket, region, dest));There was a problem hiding this comment.
Good catch! I’ve updated the code to return the existing endpoint directly instead of using format!. Thanks for pointing it out!
eureka-cpu
approved these changes
Dec 16, 2024
eureka-cpu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an optional
endpointfield in theS3UploadArgsstruct. Users can now specify a custom AWS S3-compatible endpoint, enhancing the deployment function's flexibility for working with different S3-compatible services.The changes include:
S3UploadArgsstruct to include anendpointfield.endpointif specified.endpointfield is not provided.AmazonS3Builderconfiguration to incorporate the custom endpoint.Testing
Case 1: Without
endpointfieldInput:
Expected: URL defaults to
https://example-bucket.s3.us-west-1.amazonaws.com/....Case 2: With
endpointfieldInput:
Expected: URL uses the custom endpoint
https://custom-s3-endpoint.com/....Checklist
endpointfield toS3UploadArgs.AmazonS3Builderlogic for custom endpoint.endpointfield.Related Issues
References