Upgrade pion/webrtc to v4 #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, if you're happy with it and it passed your checks that should be good! |
|
There is a performance issue that might be worth revisiting that exists because of a WebRTC workaround: #982 (comment). I don't know if you think this might fix it, and want to try pion/v4 without that workaround and see if we can remove it? Edit: Fixed brainfarts above. |
|
I don't know if v4 will fix it, but it's worth a try! I'll give it a look |
Ns2Kracy
pushed a commit
to Ns2Kracy/torrent
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pion/webrtc/v4got out of beta and was officially released last week. Looking at the breaking changes in the release notes, I don't think there should be impacts on this project. All tests pass when I run them locally.In #983 we decided to keep a separate branch for v4. I thought I'd also open a PR for it since it's no longer in beta. Are there any other checks that we could do so when know when we're ready to merge?