Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate 'api key' storage data to 'instance name' storage #143

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

falconandy
Copy link
Contributor

Summary

Migrate 'api key' storage data to 'instance name' storage.
Implementation and test are similar to Amplitude-Swift (amplitude/Amplitude-Swift#63)

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @falconandy. Overall looks good. See comments.

core/src/main/java/com/amplitude/core/Storage.kt Outdated Show resolved Hide resolved
android/src/main/java/com/amplitude/android/Amplitude.kt Outdated Show resolved Hide resolved
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @falconandy. LGTM.

@justin-fiedler justin-fiedler merged commit 67af8e3 into main Aug 22, 2023
2 checks passed
@justin-fiedler justin-fiedler deleted the AMP-82679-storage-should-use-instance-name branch August 22, 2023 23:19
github-actions bot pushed a commit that referenced this pull request Aug 23, 2023
# [1.11.0](v1.10.4...v1.11.0) (2023-08-23)

### Features

* migrate 'api key' storage data to 'instance name' storage ([#143](#143)) ([67af8e3](67af8e3))
@github-actions
Copy link

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants