Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Rfc6455Connector compatible with PHP 8.4 #53

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Make Rfc6455Connector compatible with PHP 8.4 #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Rfc6455Connector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
*/
public function __construct(
private readonly WebsocketConnectionFactory $connectionFactory = new Rfc6455ConnectionFactory(),
HttpClient $httpClient = null,
?HttpClient $httpClient = null,
private readonly ?WebsocketCompressionContextFactory $compressionContextFactory = new Rfc7692CompressionFactory(),
) {
$this->httpClient = $httpClient
Expand Down Expand Up @@ -117,7 +117,7 @@
$extensions[] = $this->compressionContextFactory->createRequestHeader();
}

if (!empty($extensions)) {

Check failure on line 120 in src/Rfc6455Connector.php

View workflow job for this annotation

GitHub Actions / PHP 8.1

RiskyTruthyFalsyComparison 

src/Rfc6455Connector.php:120:14: RiskyTruthyFalsyComparison: Operand of type list<string>|null contains type list<string>, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)

Check failure on line 120 in src/Rfc6455Connector.php

View workflow job for this annotation

GitHub Actions / PHP 8.2

RiskyTruthyFalsyComparison 

src/Rfc6455Connector.php:120:14: RiskyTruthyFalsyComparison: Operand of type list<string>|null contains type list<string>, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
$request->setHeader('sec-websocket-extensions', \implode(', ', $extensions));
}

Expand Down
Loading