Added PHP 8.4 compatibility (#9)

amphp · Nov 23, 2024 · 3ca7393 · 3ca7393
1 parent 4cf80b4
commit 3ca7393
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -18,6 +18,9 @@ jobs:
           - operating-system: 'ubuntu-latest'
             php-version: '8.3'
 
+          - operating-system: 'ubuntu-latest'
+            php-version: '8.4'
+
           - operating-system: 'windows-latest'
             php-version: '8.3'
             job-description: 'on Windows'

diff --git a/src/SqlConfig.php b/src/SqlConfig.php
@@ -101,7 +101,7 @@ final public function getUser(): ?string
         return $this->user;
     }
 
-    final public function withUser(string $user = null): static
+    final public function withUser(?string $user = null): static
     {
         $new = clone $this;
         $new->user = $user;
@@ -113,7 +113,7 @@ final public function getPassword(): ?string
         return $this->password;
     }
 
-    final public function withPassword(string $password = null): static
+    final public function withPassword(?string $password = null): static
     {
         $new = clone $this;
         $new->password = $password;
@@ -125,7 +125,7 @@ final public function getDatabase(): ?string
         return $this->database;
     }
 
-    final public function withDatabase(string $database = null): static
+    final public function withDatabase(?string $database = null): static
     {
         $new = clone $this;
         $new->database = $database;