Revert release/rollback to be before future resolution

amphp · Dec 2, 2023 · 1d0fa1e · 1d0fa1e
1 parent 6850044
commit 1d0fa1e
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/NestedTransaction.php b/src/NestedTransaction.php
@@ -177,22 +177,22 @@ public function commit(): void
         $this->awaitPendingNestedTransaction();
         $this->active = false;
 
+        $this->executor->releaseSavepoint($this->identifier);
+
         $onRollback = $this->onRollback;
         $this->transaction->onRollback(static fn () => $onRollback->isComplete() || $onRollback->complete());
         $this->onClose->complete();
-
-        $this->executor->releaseSavepoint($this->identifier);
     }
 
     public function rollback(): void
     {
         $this->awaitPendingNestedTransaction();
         $this->active = false;
 
+        $this->executor->rollbackTo($this->identifier);
+
         $this->onRollback->complete();
         $this->onClose->complete();
-
-        $this->executor->rollbackTo($this->identifier);
     }
 
     public function onCommit(\Closure $onCommit): void