[2.x] Fix implicitly nullable parameter for PHP 8.4 compatibility #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
changed the title
4 tasks
|
That's epic, dude, but what makes you think 2.x is supposed to support 8.4? |
kelunik
approved these changes
Sep 19, 2024
|
@Bilge What makes you think it's not? |
|
Thanks @kelunik.
vimeo/psalm uses this library in version 2. No doubt there will be a project to update, but for the moment I'm concentrating on PHP 8.4 compatibility. |
|
Tagged as v2.0.1: https://github.com/amphp/phpunit-util/releases/tag/v2.0.1 |
Because coroutines are a concluded experiment and anyone on 8.1 should be using fibers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 deprecates implicit nullable parameter. This fix is for the branch 2.x. There is no issue on branch 3.x.