Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use non-deprecated methods with league/uri 7 #369

Merged
merged 1 commit into from
Dec 13, 2024
Merged

use non-deprecated methods with league/uri 7 #369

merged 1 commit into from
Dec 13, 2024

Conversation

xabbuh
Copy link

@xabbuh xabbuh commented Dec 5, 2024 •
edited
Loading

@xabbuh
Copy link
Author

xabbuh commented Dec 5, 2024

see https://github.com/symfony/symfony/actions/runs/12177124641/job/33964281707?pr=59098#step:8:3179 for an example build that emits the deprecations

@trowski trowski merged commit 6cac9e1 into amphp:4.x Dec 13, 2024
0 of 6 checks passed
@xabbuh xabbuh deleted the league-uri-7 branch December 13, 2024 16:19
@xabbuh
Copy link
Author

xabbuh commented Dec 13, 2024 •
edited
Loading

Thank you @trowski! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xximwon xximwon xximwon approved these changes

@chalasr chalasr chalasr approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xabbuh @derrabus @alexandre-daubois @chalasr @xximwon @trowski