refactor: optimize start handler and service for better error handling

src/errors.rs

@@ -37,6 +37,9 @@ pub enum ApiError {
 
     #[error("Failed to delete playbook: {0}")]
     FailedToDeletePlaybook(HTTPError),
+
+    #[error("Failed to start playbook: {0}")]
+    FailedToStartPlaybook(HTTPError),
 }
 
 impl IntoResponse for ApiError {
@@ -47,6 +50,7 @@ impl IntoResponse for ApiError {
             Self::NotFoundPlaybook(e) => (StatusCode::NOT_FOUND, e.to_string()),
             Self::FailedToCreatePlaybook(e) => (StatusCode::BAD_REQUEST, e.to_string()),
             Self::FailedToDeletePlaybook(e) => (StatusCode::INTERNAL_SERVER_ERROR, e.to_string()),
+            Self::FailedToStartPlaybook(e) => (StatusCode::INTERNAL_SERVER_ERROR, e.to_string()),
         };
 
         error!("{} - {}", status, message);

src/handlers/playbook.rs

@@ -113,15 +113,17 @@ pub async fn delete(Path(id): Path<Uuid>, State(ctx): State<Arc<Context>>) -> Re
 
     Ok(StatusCode::NO_CONTENT)
 }
+
 /// start a playbook
 #[utoipa::path(
     post, path = "/v1/playbooks/{id}/actions/start",
     params(
         ("id" = Uuid, description = "The id of playbook"),
     ),
     responses(
-        (status = 204, description = "Playbook deleted successfully"),
-        (status = 404, description = "Playbook not found")
+        (status = 204, description = "Playbook start successfully"),
+        (status = 404, description = "Playbook not found"),
+        (status = 500, description = "Failed to start playbook")
     ),
     tag = "Playbooks"
 )]

src/services/playbook.rs

@@ -114,8 +114,17 @@ impl PlaybookService {
     }
 
     pub async fn start(ctx: Arc<Context>, id: Uuid) -> Result<u16> {
-        info!("Start playbooks in {}...", id);
-        ctx.client.playbooks().start(&id.to_string()).map_err(ApiError::NotFoundPlaybook)
+        let playbooks = ctx.client.playbooks();
+        match playbooks.get(&id.to_string()) {
+            Ok(_) => {
+                info!("Start playbooks in {}...", id);
+                playbooks.start(&id.to_string()).map_err(ApiError::FailedToStartPlaybook)
+            }
+            Err(e) => {
+                error!("Not found playbooks in {}, error: {}", id, e.to_string());
+                Err(ApiError::NotFoundPlaybook(e))
+            }
+        }
     }
 
     pub async fn logs(_ctx: Arc<Context>, _id: Uuid) {