refactor: Returns a PlaybookSpec instead of a PlaybookResponse

src/errors.rs

@@ -25,10 +25,15 @@ use tracing::error;
 pub enum ApiError {
     #[error("Internal Server Error")]
     InternalServerError,
+
     #[error("Not Found")]
     NotFound,
+
     #[error("Not Found Playbook: {0}")]
     NotFoundPlaybook(HTTPError),
+
+    #[error("Failed to create playbook: {0}")]
+    FailedToCreatePlaybook(HTTPError),
 }
 
 impl IntoResponse for ApiError {
@@ -37,7 +42,9 @@ impl IntoResponse for ApiError {
             Self::InternalServerError => (StatusCode::INTERNAL_SERVER_ERROR, self.to_string()),
             Self::NotFound => (StatusCode::NOT_FOUND, self.to_string()),
             Self::NotFoundPlaybook(e) => (StatusCode::NOT_FOUND, e.to_string()),
+            Self::FailedToCreatePlaybook(e) => (StatusCode::BAD_REQUEST, e.to_string()),
         };
+
         error!("{} - {}", status, message);
         (status, Json(json!({ "message": message }))).into_response()
     }

src/handlers/playbook.rs

@@ -37,7 +37,7 @@ use crate::services::playbook::PlaybookService;
         content_type = "application/json"
     ),
     responses(
-        (status = 201, description = "Playbook created successfully", body = PlaybookResponse)
+        (status = 201, description = "Playbook created successfully", body = PlaybookSpec)
     ),
     tag = "Playbooks"
 )]

src/responses/playbook.rs

@@ -14,24 +14,9 @@
 
 use amp_common::scm::content::Content;
 use amp_common::scm::git::Tree;
-use chrono::{DateTime, Utc};
 use serde::{Deserialize, Serialize};
 use utoipa::ToSchema;
 
-#[derive(Serialize, Deserialize, ToSchema)]
-pub struct PlaybookResponse {
-    /// The playbook ID in Amphitheatre.
-    pub id: String,
-    /// The title of the playbook.
-    pub title: String,
-    /// The description of the playbook.
-    pub description: String,
-    /// When the playbook was created in Amphitheatre.
-    pub created_at: DateTime<Utc>,
-    /// When the playbook was last updated in Amphitheatre.
-    pub updated_at: DateTime<Utc>,
-}
-
 #[derive(Serialize, Deserialize, ToSchema)]
 pub struct FilesResponse {
     /// The file details.

src/services/playbook.rs

@@ -80,12 +80,12 @@ impl PlaybookService {
     }
 
     pub async fn create(ctx: Arc<Context>, req: &CreatePlaybookRequest) -> Result<PlaybookSpec> {
-        let playbook_payload = PlaybookPayload {
+        let payload = PlaybookPayload {
             title: req.title.clone(),
             description: req.description.clone().unwrap_or_default(),
             preface: req.preface.clone(),
         };
-        ctx.client.playbooks().create(playbook_payload).map_err(ApiError::NotFoundPlaybook)
+        ctx.client.playbooks().create(payload).map_err(ApiError::FailedToCreatePlaybook)
     }
 
     pub async fn update(ctx: Arc<Context>, id: Uuid, req: Synchronization) -> Result<u16> {

src/swagger.rs

@@ -15,7 +15,7 @@
 use utoipa::OpenApi;
 use utoipa_swagger_ui::SwaggerUi;
 
-use crate::{handlers, requests, responses};
+use crate::{handlers, requests};
 
 #[derive(OpenApi)]
 #[openapi(
@@ -31,7 +31,6 @@ use crate::{handlers, requests, responses};
         schemas(
             requests::playbook::CreatePlaybookRequest,
             requests::playbook::UpdatePlaybookRequest,
-            responses::playbook::PlaybookResponse,
 
             amp_common::resource::ActorSpec,
             amp_common::resource::CharacterSpec,