Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ruby from 3.2.2 to 3.3.4 #568

Merged
merged 1 commit into from
Aug 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/assets-precompile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:

steps:
- uses: actions/checkout@v4
- name: Set up Ruby 3.2.2
- name: Set up Ruby 3.3.4
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.2.2
ruby-version: 3.3.4
bundler-cache: true

- name: Check ability to precompile current assets
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/brakeman-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Set up Ruby 3.2.2
- name: Set up Ruby 3.3.4
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.2.2
ruby-version: 3.3.4
bundler-cache: true

- name: Scan
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
BUNDLE_WITHOUT: development
steps:
- uses: actions/checkout@v4
- name: Set up Ruby 3.2.2
- name: Set up Ruby 3.3.4
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.2.2
ruby-version: 3.3.4
bundler-cache: true

- name: Run static code analysis using rubocop
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ui-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Set up Ruby 3.2.2
- name: Set up Ruby 3.3.4
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.2.2
ruby-version: 3.3.4
bundler-cache: true

- name: Setup Database
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ Rails/FilePath:
RSpec/ImplicitExpect:
EnforcedStyle: should
AllCops:
TargetRubyVersion: 3.2.2
TargetRubyVersion: 3.3.4
NewCops: enable
Exclude:
- 'node_modules/**/*'
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.2
3.3.4
7 changes: 1 addition & 6 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
source 'https://rubygems.org'
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

ruby '3.2.2'
ruby file: '.ruby-version'

gem 'bcrypt', '~> 3.1.20'
gem 'bootsnap', '>= 1.4.4', require: false
Expand All @@ -24,11 +24,6 @@ gem 'rubyzip', require: 'zip'
gem 'sassc-rails'
gem 'terser'

# Temporarily fix for ruby 3.1
gem 'net-imap', require: false
gem 'net-pop', require: false
gem 'net-smtp', require: false

group :development, :test do
gem 'brakeman'
gem 'capybara'
Expand Down
7 changes: 2 additions & 5 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -440,9 +440,6 @@ DEPENDENCIES
jquery-rails
letter_opener
listen (~> 3.9)
net-imap
net-pop
net-smtp
pg (~> 1.5)
puma (~> 6.4)
pundit
Expand All @@ -467,7 +464,7 @@ DEPENDENCIES
tzinfo-data

RUBY VERSION
ruby 3.2.2p53
ruby 3.3.4p94

BUNDLED WITH
2.4.20
2.5.18
Loading