Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few ideas for fluentRevealNavbar.uc.js #77
base: master
Are you sure you want to change the base?
Few ideas for fluentRevealNavbar.uc.js #77
Changes from 13 commits
d7bc621
0cc13b7
0f5df53
e45dba3
130957e
293cc72
75f9e8d
ab69194
a0dec4f
aeceba5
73c0482
77bf366
8126494
7af0251
97905a7
d1091d5
94dc10c
2179e71
4586237
a2cfeb5
0c82178
af6d576
96f3ba2
4cf3620
aeb10b2
cd09975
0c96706
819fd64
91c0217
e2aa84f
3fafeff
36a2814
80ac4bb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to change the comments too since this changes the meaning of filterDy.
It's filtering out mouse events that are more than {gradientSize} pixels below the toolbar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reasoning for this is that the toolbar height is variable, not fixed. For example, Ctrl+Shift+B makes the bookmarks toolbar appear, which significantly increases its height. There are also infobars that can rarely appear below the main toolbar, above the browser content viewer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code below needs to be fixed, or there is a bug when you move the mouse around the top of the page on about:config or about:preferences, etc. It's because they are in the parent process so their true event targets pass all the way up to the chrome window listener (normally the event target we see would be
<browser>
).It's better if we just use MousePosTracker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't know about this bug, so my first thought was this check was added just for UX convenience. So now this should be handled by new
getComputedStyle(el).pointerEvents == "none"
check, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There shouldn't be logs