Skip to content

Commit

Permalink
[BUG] Make the gracefulperiod to be 0 for pod deletion (chroma-core#2011
Browse files Browse the repository at this point in the history
)

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - Make the gracefulperiod to be 0 for pod deletion
 - New functionality
	 - ...

## Test plan
*How are these changes tested?*

- [ ] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
*Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
repository](https://github.com/chroma-core/docs)?*
  • Loading branch information
Ishiihara authored Apr 15, 2024
1 parent 8848300 commit f44d9e8
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion go/pkg/memberlist_manager/memberlist_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,10 @@ func createFakePod(ip string, clientset kubernetes.Interface) {
}

func deleteFakePod(ip string, clientset kubernetes.Interface) {
clientset.CoreV1().Pods("chroma").Delete(context.TODO(), ip, metav1.DeleteOptions{})
gracefulPeriodSeconds := int64(0)
clientset.CoreV1().Pods("chroma").Delete(context.TODO(), ip, metav1.DeleteOptions{
GracePeriodSeconds: &gracefulPeriodSeconds,
})
}

func TestMemberlistManager(t *testing.T) {
Expand Down

0 comments on commit f44d9e8

Please sign in to comment.