Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YarpSensorBridge: Drop use of IGenericSensor and IAnalogSensor for reading sensors #912

Open
traversaro opened this issue Nov 15, 2024 · 3 comments

Comments

@traversaro
Copy link
Collaborator

Now that all the IMUs and FTs in the iCub and ergoCub robots we use have been migrated to multipleAnalogSensors interfaces, we can drop the use of IGenericSensor and IAnalogSensor in the YarpSensorBridge. Similarly to #911, we could take the occasion to just drop any custom remapping logic from YarpSensorBridge, and use use a multipleanalogsensorsremapper.

@GiulioRomualdi
Copy link
Member

I agree! It will simplify the logic!

@traversaro traversaro changed the title YarpSensorBridge: Drop use of IGenericSensor and IAnalogSensor YarpSensorBridge: Drop use of IGenericSensor and IAnalogSensor for reading sensors Nov 15, 2024
@traversaro
Copy link
Collaborator Author

I renamed the title as I realized that we are also using IGenericSensors to read the cartesian wrenches, and that info is not published by WBD with a usual chain of C++ device interface ---> NWS ---> NWC , so let's leave them aside for now. I wonder if we could just expose those using the existing https://www.yarp.it/v3.4/classyarp_1_1dev_1_1ISixAxisForceTorqueSensors.html inteface. If you think about it, in the end external wrenches estimates could be tought of virtual FT sensors, so that could make sense, but that is OT here.

@GiulioRomualdi
Copy link
Member

Yes I think It is fine to expose them as six axis ft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants