-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): typescript prettier vitest #57
base: main
Are you sure you want to change the base?
Changes from all commits
5990a67
d262751
dec4806
7e83db3
6f3e83b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
{ | ||
"presets": ["amex"] | ||
"presets": ["amex"], | ||
"plugins": ["@babel/plugin-transform-typescript"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
lib | ||
node_modules | ||
test-results | ||
coverage |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,50 @@ | ||
{ | ||
"extends": "amex" | ||
"extends": ["amex", "plugin:@typescript-eslint/recommended", "prettier"], | ||
"settings": { "import/resolver": { "typescript": {} } }, | ||
"parserOptions": { | ||
"project": true, | ||
"extraFileExtensions": [".json"] | ||
}, | ||
"parser": "@typescript-eslint/parser", | ||
"plugins": ["@typescript-eslint"], | ||
Comment on lines
+3
to
+9
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we add a ts dir to the eslint config like we did for prettier? I think that updating the eslint config with TS support should block this PR |
||
"overrides": [ | ||
{ | ||
"files": ["__tests__/**"], | ||
"extends": ["amex/test", "plugin:@typescript-eslint/recommended", "prettier"], | ||
"rules": { | ||
"import/extensions": [ | ||
"error", | ||
"ignorePackages", | ||
{ | ||
"ts": "never", | ||
"tsx": "never", | ||
"js": "never", | ||
"jsx": "never" | ||
} | ||
] | ||
} | ||
}, | ||
{ | ||
"files": ["src/**"], | ||
"extends": [ | ||
"amex", | ||
"plugin:@typescript-eslint/recommended", | ||
"plugin:@typescript-eslint/strict-type-checked", | ||
"prettier" | ||
], | ||
"rules": { | ||
"import/extensions": [ | ||
"error", | ||
"ignorePackages", | ||
{ | ||
"ts": "never", | ||
"tsx": "never", | ||
"js": "never", | ||
"jsx": "never" | ||
} | ||
] | ||
} | ||
} | ||
], | ||
"ignorePatterns": ["types"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,11 @@ | ||
test-results | ||
.jest-cache | ||
coverage | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there an There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. addressed in f04d16d |
||
node_modules | ||
lib | ||
*.log | ||
*.swp | ||
*.tgz | ||
types | ||
|
||
.idea | ||
.vscode |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
test-results | ||
node_modules | ||
src | ||
!types/src | ||
*.log | ||
*.swp | ||
package-lock.json | ||
commitlint.config.js | ||
.jest-cache | ||
coverage |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
/types | ||
/lib | ||
/test-results | ||
coverage |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"singleQuote": true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does babel-preset-amex need TS support?
e.g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly, we maybe don't even need a separate file. could just use overrides for
.ts
and.tsx