Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: limit packed files #56

Closed
wants to merge 1 commit into from
Closed

chore: limit packed files #56

wants to merge 1 commit into from

Conversation

smackfu
Copy link
Member

@smackfu smackfu commented Nov 11, 2024 •
edited
Loading

Description

Currently a bunch of junk is in the packed tar.gz like tests and github actions.

This changes to only include the lib dir plus other npm defaults.

$ npm pack

> @americanexpress/[email protected] prepare
> husky install

husky - Git hooks installed
npm notice
npm notice 📦  @americanexpress/[email protected]
npm notice Tarball Contents
npm notice 10.3kB LICENSE.txt
npm notice 2.6kB README.md
npm notice 1.3kB lib/collectBuiltState.js
npm notice 1.5kB lib/immutable.js
npm notice 1.3kB lib/index.js
npm notice 2.0kB package.json

This decreases the size from 17.9kb packed to 6.5kb.

@smackfu smackfu requested review from a team as code owners November 11, 2024 16:20
10xLaCroixDrinker
10xLaCroixDrinker requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@10xLaCroixDrinker 10xLaCroixDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead use an .npmignore?

@smackfu
Copy link
Member Author

smackfu commented Nov 15, 2024

Can you instead use an .npmignore?

This article makes it seem like files is better?
https://medium.com/@jdxcode/for-the-love-of-god-dont-use-npmignore-f93c08909d8d

@github-actions GitHub Actions
Copy link
Contributor

This pull request is stale because it has been open 30 days with no activity.

@smackfu
Copy link
Member Author

smackfu commented Dec 23, 2024

#57 conflicts with this.

@smackfu smackfu closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@10xLaCroixDrinker 10xLaCroixDrinker 10xLaCroixDrinker requested changes

Assignees
No one assigned
Labels
one-app-team-review-requested stale-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smackfu @10xLaCroixDrinker