Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support typescript extensions #131

Merged

Conversation

smackfu
Copy link
Member

@smackfu smackfu commented Nov 12, 2024

Description

For import/no-extraneous-dependencies rule, support both typescript and javascript extensions.

Motivation and Context

For the purposes of this rule, typescript vs javascript is not relevant and both should be supported.

How Has This Been Tested?

Packed and installed in repo using this ruleset and verified resolves error.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Copy link
Member

@zacowan zacowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of the other config (webpack, jest, vue, etc.) files also support .ts extensions?

@10xLaCroixDrinker 10xLaCroixDrinker merged commit 733c090 into americanexpress:main Nov 15, 2024
5 checks passed
oneamexbot added a commit that referenced this pull request Nov 15, 2024
# [16.4.0](v16.3.0...v16.4.0) (2024-11-15)

### Features

* support typescript extensions ([#131](#131)) ([733c090](733c090))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 16.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@smackfu
Copy link
Member Author

smackfu commented Nov 15, 2024

Do any of the other config (webpack, jest, vue, etc.) files also support .ts extensions?

Doubtful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants